-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rand
to 0.9.0
#1487
Upgrade rand
to 0.9.0
#1487
Conversation
Some tests are failing because macro error output has changed. I also couldn't build |
I've looked at the errors, and I'm pretty sure they are mostly the same. Angle brackets around types got replaced with backticks in a couple of places and the last Test output
|
2a50859
to
30132ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meat of this looks fine, but a couple nits. Updating unrelated tests should be a separate commit or PR.
30132ec
to
546771d
Compare
I've split the changes into two commits, |
Changes to make the tests build with rand 0.9 should not be separated from the change to update to rand 0.9. What should be separated out are the changes not related to updating |
546771d
to
6c1d78c
Compare
6c1d78c
to
626fd85
Compare
Ah, got it! Sorry, I was confused, thought that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Bumps the
rand
version.Things of note:
new_random_generic
inbase::construction
usedthread_rng
. This function is now locked under athread_rng
feature, so I added it to nalgebra'srand
.