Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #287 by Inlead: Add inline comment and change version. #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ding_campaign.admin.inc
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ function ding_campaign_campaign_rule_form_submit($form, &$form_state) {
->condition('cid', $nid)
->execute();

// Clear node cache after campaign rule was deleted from DB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate a comment describing why it is necessary to clear the cache at this point.

entity_get_controller('node')->resetCache(array($nid));

// Add new rules.
Expand Down
138 changes: 69 additions & 69 deletions ding_campaign.info
Original file line number Diff line number Diff line change
@@ -1,69 +1,69 @@
name = Ding campaign
description = Campaign system. Displays context-sensitive, ad-like campaigns.
core = 7.x
package = Ding!
version = 7.x-2.3.1+easy
project = ding_campaign
dependencies[] = ctools
dependencies[] = entityreference
dependencies[] = features
dependencies[] = image
dependencies[] = list
dependencies[] = media
dependencies[] = og_ui
dependencies[] = scheduler
dependencies[] = strongarm
dependencies[] = text
configure = admin/config/ding/campaign
features[ctools][] = strongarm:strongarm:1
features[features_api][] = api:2
features[field_base][] = ding_campaign_group_ref
features[field_base][] = field_camp_behavior
features[field_base][] = field_camp_image
features[field_base][] = field_camp_link
features[field_base][] = field_camp_settings
features[field_base][] = field_camp_text_full
features[field_base][] = field_camp_text_plain
features[field_base][] = field_camp_weight
features[field_instance][] = node-ding_campaign-ding_campaign_group_ref
features[field_instance][] = node-ding_campaign-field_camp_behavior
features[field_instance][] = node-ding_campaign-field_camp_image
features[field_instance][] = node-ding_campaign-field_camp_link
features[field_instance][] = node-ding_campaign-field_camp_settings
features[field_instance][] = node-ding_campaign-field_camp_text_full
features[field_instance][] = node-ding_campaign-field_camp_text_plain
features[field_instance][] = node-ding_campaign-field_camp_weight
features[image][] = ding_campaign_p_100
features[image][] = ding_campaign_p_25
features[image][] = ding_campaign_p_33
features[image][] = ding_campaign_p_50
features[image][] = ding_campaign_p_66
features[image][] = ding_campaign_p_75
features[image][] = ding_campaign_w_180
features[image][] = ding_campaign_w_280
features[image][] = ding_campaign_w_380
features[image][] = ding_campaign_w_480
features[node][] = ding_campaign
features[variable][] = comment_anonymous_ding_campaign
features[variable][] = comment_default_mode_ding_campaign
features[variable][] = comment_default_per_page_ding_campaign
features[variable][] = comment_ding_campaign
features[variable][] = comment_form_location_ding_campaign
features[variable][] = comment_preview_ding_campaign
features[variable][] = comment_subject_field_ding_campaign
features[variable][] = field_bundle_settings_node__ding_campaign
features[variable][] = language_content_type_ding_campaign
features[variable][] = menu_options_ding_campaign
features[variable][] = menu_parent_ding_campaign
features[variable][] = node_options_ding_campaign
features[variable][] = node_preview_ding_campaign
features[variable][] = node_submitted_ding_campaign
features[variable][] = scheduler_publish_enable_ding_campaign
features[variable][] = scheduler_publish_required_ding_campaign
features[variable][] = scheduler_publish_revision_ding_campaign
features[variable][] = scheduler_publish_touch_ding_campaign
features[variable][] = scheduler_unpublish_enable_ding_campaign
features[variable][] = scheduler_unpublish_required_ding_campaign
features[variable][] = scheduler_unpublish_revision_ding_campaign
features_exclude[dependencies][options] = options
mtime = 1431613941
name = Ding campaign
description = Campaign system. Displays context-sensitive, ad-like campaigns.
core = 7.x
package = Ding!
version = 7.x-2.3.1
project = ding_campaign
dependencies[] = ctools
dependencies[] = entityreference
dependencies[] = features
dependencies[] = image
dependencies[] = list
dependencies[] = media
dependencies[] = og_ui
dependencies[] = scheduler
dependencies[] = strongarm
dependencies[] = text
configure = admin/config/ding/campaign
features[ctools][] = strongarm:strongarm:1
features[features_api][] = api:2
features[field_base][] = ding_campaign_group_ref
features[field_base][] = field_camp_behavior
features[field_base][] = field_camp_image
features[field_base][] = field_camp_link
features[field_base][] = field_camp_settings
features[field_base][] = field_camp_text_full
features[field_base][] = field_camp_text_plain
features[field_base][] = field_camp_weight
features[field_instance][] = node-ding_campaign-ding_campaign_group_ref
features[field_instance][] = node-ding_campaign-field_camp_behavior
features[field_instance][] = node-ding_campaign-field_camp_image
features[field_instance][] = node-ding_campaign-field_camp_link
features[field_instance][] = node-ding_campaign-field_camp_settings
features[field_instance][] = node-ding_campaign-field_camp_text_full
features[field_instance][] = node-ding_campaign-field_camp_text_plain
features[field_instance][] = node-ding_campaign-field_camp_weight
features[image][] = ding_campaign_p_100
features[image][] = ding_campaign_p_25
features[image][] = ding_campaign_p_33
features[image][] = ding_campaign_p_50
features[image][] = ding_campaign_p_66
features[image][] = ding_campaign_p_75
features[image][] = ding_campaign_w_180
features[image][] = ding_campaign_w_280
features[image][] = ding_campaign_w_380
features[image][] = ding_campaign_w_480
features[node][] = ding_campaign
features[variable][] = comment_anonymous_ding_campaign
features[variable][] = comment_default_mode_ding_campaign
features[variable][] = comment_default_per_page_ding_campaign
features[variable][] = comment_ding_campaign
features[variable][] = comment_form_location_ding_campaign
features[variable][] = comment_preview_ding_campaign
features[variable][] = comment_subject_field_ding_campaign
features[variable][] = field_bundle_settings_node__ding_campaign
features[variable][] = language_content_type_ding_campaign
features[variable][] = menu_options_ding_campaign
features[variable][] = menu_parent_ding_campaign
features[variable][] = node_options_ding_campaign
features[variable][] = node_preview_ding_campaign
features[variable][] = node_submitted_ding_campaign
features[variable][] = scheduler_publish_enable_ding_campaign
features[variable][] = scheduler_publish_required_ding_campaign
features[variable][] = scheduler_publish_revision_ding_campaign
features[variable][] = scheduler_publish_touch_ding_campaign
features[variable][] = scheduler_unpublish_enable_ding_campaign
features[variable][] = scheduler_unpublish_required_ding_campaign
features[variable][] = scheduler_unpublish_revision_ding_campaign
features_exclude[dependencies][options] = options
mtime = 1431613941