Adding support for controller input and method in an array with the n… #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 25, 2020 14:27
|
@azakhozhy Would be great if you can summarize the background/aim of this PR in description. Also avoid changing the spacing style in code comments/documentation.. |
| @@ -341,6 +341,14 @@ public function addRoute($methods, $uri, $action) | |||
| $action = implode('@', $action); | |||
| $action = ['uses' => $action, 'controller' => $action]; | |||
| } | |||
|
|
|||
| // For named routes and syntax: | |||
There was a problem hiding this comment.
Wouldn't $action already be changed by the above ? So it won't be the same as in the routes file anymore ?
|
Sorry I just realised I wrote a review but didn't submit it 🤦 |
Lol, happens to me too, I think GitHub should have a prompt to submit before you leave the page.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ame of the route