Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Music Controls #137

Merged
merged 8 commits into from
Jan 22, 2025
Merged

More Music Controls #137

merged 8 commits into from
Jan 22, 2025

Conversation

Flight-Lab
Copy link
Contributor

Expanding music player controls from @jeroenterheerdt.

Add raise/lower as options in the music volume up and down commands.

Add mute/unmute commands.

Add set music volume command.

Set music volume to a specific level.
Correct indents for triggers. 
Correct input name in triggers for pause_music.
Remove assist response when setting music volume as to not distract from music.
I accidentally deleted a word. Oops. Now it's back.
@dinki
Copy link
Owner

dinki commented Jan 22, 2025

Thanks for this for sure. Does this also address:

#136

or does that need to be pushed too?

@jeroenterheerdt Please post here if you have tried these and they are working. I will install later today as well but more testing the better.

Thanks to you both!

@Flight-Lab
Copy link
Contributor Author

Yes, it does. I saw #135 get closed but didn't see #136 come in after.

@jeroenterheerdt
Copy link
Contributor

#136 works, I have not tested this one and don't have time to test it at the moment :(

@dinki
Copy link
Owner

dinki commented Jan 22, 2025

Thanks for the great contribution!

@dinki dinki merged commit 1b5b666 into dinki:main Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants