Merge pull request #38 from Jeff-CCH/test/optimize-e2e

fix: uniswap v3 slippage in e2e test
dinngo · Jan 16, 2024 · 0f8a54a · 0f8a54a
2 parents e3959f7 + f6d6c43
commit 0f8a54a
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/.changeset/great-boxes-pull.md b/.changeset/great-boxes-pull.md
@@ -0,0 +1,5 @@
+---
+'@protocolink/logics': patch
+---
+
+fix uniswap v3 slippage in e2e test
diff --git a/.github/workflows/e2e-test-latest.yml b/.github/workflows/e2e-test-latest.yml
@@ -1,4 +1,4 @@
-name: E2E Test
+name: E2E Latest
 
 on:
   push:

diff --git a/.github/workflows/e2e-test-mainnet-pb.yml b/.github/workflows/e2e-test-mainnet-pb.yml
@@ -1,4 +1,4 @@
-name: E2E Test
+name: E2E Mainnet Pinned Block
 
 on:
   push:

diff --git a/test/logics/aave-v2/withdraw.test.ts b/test/logics/aave-v2/withdraw.test.ts
@@ -84,7 +84,7 @@ describe('mainnet-pb: Test AaveV2 Withdraw Logic', function () {
       const transactionRequest = routerKit.buildExecuteTransactionRequest({ permit2Datas, routerLogics, tokensReturn });
       await expect(user.sendTransaction(transactionRequest)).to.not.be.reverted;
       await expect(user.address).to.changeBalance(input.token, -input.amount, 1);
-      await expect(user.address).to.changeBalance(output.token, output.amount);
+      await expect(user.address).to.changeBalance(output.token, output.amount, 1);
     });
   });
 });
diff --git a/test/logics/uniswap-v3/swap-token.test.ts b/test/logics/uniswap-v3/swap-token.test.ts
@@ -31,7 +31,7 @@ describe('mainnet-pb: Test UniswapV3 SwapToken Logic', function () {
       params: {
         input: new common.TokenAmount(mainnetTokens.USDC, '1000'),
         tokenOut: mainnetTokens.ETH,
-        slippage: 100,
+        slippage: 500,
       },
     },
     {
@@ -53,7 +53,7 @@ describe('mainnet-pb: Test UniswapV3 SwapToken Logic', function () {
       params: {
         input: new common.TokenAmount(mainnetTokens.USDC, '1000'),
         tokenOut: mainnetTokens.ETH,
-        slippage: 100,
+        slippage: 500,
       },
       balanceBps: 5000,
     },
@@ -76,7 +76,7 @@ describe('mainnet-pb: Test UniswapV3 SwapToken Logic', function () {
       params: {
         tokenIn: mainnetTokens.USDC,
         output: new common.TokenAmount(mainnetTokens.ETH, '1'),
-        slippage: 100,
+        slippage: 500,
       },
     },
     {

diff --git a/test/logics/utility/flash-loan-aggregrator.test.ts b/test/logics/utility/flash-loan-aggregrator.test.ts
@@ -33,12 +33,9 @@ describe('mainnet-pb: Test Utility FlashLoanAggregator Logic', function () {
     { loans: new common.TokenAmounts([mainnetTokens.WETH, '0.01'], [morphoblue.mainnetTokens.wstETH, '0.01']) },
     { repays: new common.TokenAmounts([mainnetTokens.WETH, '0.01'], [morphoblue.mainnetTokens.wstETH, '0.01']) },
     // aave-v3
-    // TODO: consider server_error even run as single file
-    // TODOL: unknown block bnumber
     { loans: new common.TokenAmounts([aavev3.mainnetTokens['1INCH'], '1'], [aavev3.mainnetTokens.USDC, '1']) },
     { repays: new common.TokenAmounts([aavev3.mainnetTokens['1INCH'], '1'], [aavev3.mainnetTokens.USDC, '1']) },
     { protocolId: 'aave-v3', loans: new common.TokenAmounts([mainnetTokens.WETH, '1'], [mainnetTokens.USDC, '1']) },
-    // TODOL: unknown block bnumber
     { protocolId: 'aave-v3', repays: new common.TokenAmounts([mainnetTokens.WETH, '1'], [mainnetTokens.USDC, '1']) },
   ];