Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ZeroEx takerAddress #48

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: ZeroEx takerAddress #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-penguins-kiss.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@protocolink/logics': patch
---

fix ZeroEx takerAddress
13 changes: 2 additions & 11 deletions src/logics/zeroex-v4/logic.swap-token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,8 @@ export class SwapTokenLogic

async quote(params: SwapTokenLogicParams) {
try {
const {
input,
tokenOut,
slippage,
excludedSources,
includedSources,
apiKey,
takerAddress: takerAddressInput,
} = params;
const { input, tokenOut, slippage, excludedSources, includedSources, apiKey, takerAddress } = params;
const slippagePercentage = slippage != null ? slippageToZeroEx(slippage) : undefined;
const takerAddress = takerAddressInput && (await this.calcAgent(takerAddressInput));
const url = this.getAPIBaseUrl(this.chainId) + `swap/v1/price`;
const {
data: { buyAmount },
Expand Down Expand Up @@ -114,7 +105,7 @@ export class SwapTokenLogic
async build(fields: SwapTokenLogicFields, { account }: SwapTokenLogicOptions) {
const { input, output, slippage, excludedSources, includedSources, apiKey } = fields;
const slippagePercentage = slippage != null ? slippageToZeroEx(slippage) : undefined;
const takerAddress = await this.calcAgent(account);
const takerAddress = account;
const url = this.getAPIBaseUrl(this.chainId) + `swap/v1/quote`;
const {
data: { buyAmount, data, to, allowanceTarget: approveTo },
Expand Down
Loading