Close the body after reading the response body information (coredns#5907

) Signed-off-by: Fish-pro <[email protected]>
diogenxs · Feb 15, 2023 · 156da74 · 156da74
1 parent 8a0d3ba
commit 156da74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/core/dnsserver/server_https_test.go b/core/dnsserver/server_https_test.go
@@ -61,6 +61,7 @@ func TestCustomHTTPRequestValidator(t *testing.T) {
 			if res.StatusCode != tc.expected {
 				t.Error("unexpected HTTP code", res.StatusCode)
 			}
+			res.Body.Close()
 		})
 	}
 }
diff --git a/test/reload_test.go b/test/reload_test.go
@@ -123,6 +123,7 @@ func TestReloadMetricsHealth(t *testing.T) {
 	}
 	const proc = "coredns_build_info"
 	metrics, _ := io.ReadAll(resp.Body)
+	resp.Body.Close()
 	if !bytes.Contains(metrics, []byte(proc)) {
 		t.Errorf("Failed to see %s in metric output", proc)
 	}
@@ -135,6 +136,7 @@ func collectMetricsInfo(addr string, procs ...string) error {
 		return err
 	}
 	metrics, _ := io.ReadAll(resp.Body)
+	resp.Body.Close()
 	for _, p := range procs {
 		if !bytes.Contains(metrics, []byte(p)) {
 			return fmt.Errorf("failed to see %s in metric output \n%s", p, metrics)