-
-
Notifications
You must be signed in to change notification settings - Fork 64
Update Hasura config defaults #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -414,10 +414,10 @@ class HasuraConfig: | |
admin_secret: str | None = Field(default=None, repr=False) | ||
create_source: bool = False | ||
source: str = 'default' | ||
select_limit: int = 1000 | ||
select_limit: int = 10_000 | ||
allow_aggregations: bool = True | ||
allow_inconsistent_metadata: bool = False | ||
camel_case: bool = False | ||
camel_case: bool = True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. false? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently there's an inconsistency. In config class default is False. In environment configs provided with project template default is True. Thus, de-facto default is True. Changing default in the template would be a more breaking change. I'll double check env vars in our deployments after merging this. |
||
rest: bool = True | ||
http: HttpConfig | None = None | ||
hide_internal: bool = False | ||
|
Uh oh!
There was an error while loading. Please reload this page.