Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Search #59

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Implement Search #59

merged 1 commit into from
Sep 24, 2024

Conversation

3y3
Copy link
Member

@3y3 3y3 commented Sep 20, 2024 •
edited
Loading

Concepts:

  • Add a local Suggest component. This is a wrapper around @diplodoc/components/Suggest.
  • Implement SearchProvider, which should be passed to the Suggest component.
  • The SearchProvider consists of two parts: a suggest adapter connected to the suggest component, and an isolated worker runtime where the main search algorithm should be implemented.
  • The worker itself does not contain any implemented search algorithms, and tries to load them from an external resource using the importScripts API.
  • Build output manifest adopted to new reality, with additional async worker module and new search entry.

@3y3 3y3 merged commit 5813e0e into master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martyanovandrey martyanovandrey martyanovandrey approved these changes

@makamekm makamekm makamekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3y3 @makamekm @martyanovandrey