[WIP] fix: remove event listeners on unmount #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3y3
reviewed
Aug 4, 2023
| mermaid.initialize(config); | ||
| return mermaid.run(options); | ||
| onUnmountRef.current = mermaid.initialize(config); | ||
| mermaid.run(options); |
There was a problem hiding this comment.
Please return promise from mermaid.run
3y3
reviewed
Aug 4, 2023
| const config = omit(props, [ 'querySelector', 'nodes', 'onError' ]); | ||
| const options = pick(props, [ 'querySelector', 'nodes' ]); | ||
| const config = omit(props, ['querySelector', 'nodes', 'onError']); | ||
| const options = pick(props, ['querySelector', 'nodes']); |
3y3
reviewed
Aug 4, 2023
| @@ -64,9 +64,22 @@ async function next(): Promise<void> { | |||
|
|
|||
| const { zoom } = mermaid.mermaidAPI.getConfig() as InitConfig; | |||
|
|
|||
| let onUnmount = [() => { | |||
There was a problem hiding this comment.
This variable assignrd only once, why let?
vsesh
reviewed
Aug 4, 2023
| }); | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| export function useMermaid() { | ||
| const [ mermaid, setMermaid ] = useState<Parameters<Callback>[0] | null>(null); | ||
| const onUnmountRef = useRef<any>() |
There was a problem hiding this comment.
You forgot to add ";" at the end of the operation. What about linters in the current project?
| let onUnmount = [() => { | ||
| document.removeEventListener('click', zoomBehavior) | ||
| }] | ||
|
|
||
| document.removeEventListener('click', zoomBehavior); |
| document.addEventListener('click', (e) => { | ||
| const cb = zoomBehavior(e) | ||
| if(cb){ | ||
| onUnmount.push(cb) |
There was a problem hiding this comment.
I don't understand what is happening here.
Why do you collect the zoomBehavior handler on every click in the document?
There was a problem hiding this comment.
| @@ -64,9 +64,22 @@ async function next(): Promise<void> { | |||
|
|
|||
| const { zoom } = mermaid.mermaidAPI.getConfig() as InitConfig; | |||
|
|
|||
| let onUnmount = [() => { | |||
| document.removeEventListener('click', zoomBehavior) | |||
There was a problem hiding this comment.
This string doesn't make sense because nobody calls
document.addEventListener('click', zoomBehavior)
ldrv565
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.