Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add merge included autotitles #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add merge included autotitles #500

wants to merge 1 commit into from

Conversation

makamekm
Copy link
Contributor

@makamekm makamekm commented Sep 5, 2024

No description provided.

3y3
3y3 reviewed Sep 5, 2024
View reviewed changes
src/transform/plugins/includes/utils.ts Outdated

const includesPaths: string[] = [];

const INCLUDE_AUTOTITLE_REGEXP = /\[{#T}\]\(\s*(.+?)\s*\)/g;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RegExp with g flag at top level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@makamekm makamekm force-pushed the add-merge-autotiles branch 4 times, most recently from 78a6057 to 028478b Compare September 6, 2024 10:09
@makamekm makamekm force-pushed the add-merge-autotiles branch from 028478b to e0a1c62 Compare September 6, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3y3 3y3 3y3 left review comments

@martyanovandrey martyanovandrey Awaiting requested review from martyanovandrey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makamekm @3y3