Issue #6: Changing default aperture in lsst_comet_activity.py

[astronomerritt]

Change Description

Closes #6. The default aperture used by lsst_comet_activity.py was set to the seeing. As per conversation with Colin Snodgrass outlined in the issue, using the seeing will cause comets to seem brighter at poorer seeing, which is obviously not the case.

• My PR includes a link to the issue that I am addressing

Solution Description

I have simply changed the aperture to 1 arcsec. The user may feel free to change it to something larger at their own risk (lsstcomet assumes infinite coma, so large apertures will produce spurious results).

I have also updated the test.

Code Quality

• I have read the Contribution Guide
• My code follows the code style of this project
• My code builds (or compiles) cleanly without any errors or warnings
• My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Other Change Checklist

• Any new or updated docstrings use the NumPy docstring format.
• I have updated the tutorial to highlight my new feature (if appropriate)
• I have added unit/End-to-End (E2E) test cases to cover any changes
• My change includes a breaking change
  • My change includes backwards compatibility and deprecation warnings (if possible)

[drewoldag]

From a software engineering perspective this is fine. I'll leave it to @mschwamb to verify the science side of things :)

[mschwamb]

All fine, though can you add a comment @astronomerritt explaining what the default hardcoded value is/represents ?