Added a culling filter for faint objects #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what's going on, there's a huge bunch of tests that are being update with spaces. It makes it difficult to review this. |
|
Maybe it was the linter. Maybe black preferred some changes once run? - There's one conflict now needing to be to deal with, but it looks pretty straight forward to resolve |
|
Looks like the conflict is linting |
5 tasks
mschwamb
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a culling filter (fixes #1067) that gets rid of faint objects before ephemeris generation (thank you to Steph+Pedro for developing the majority of this!). Adds a unit test as well for this + additional functions on grabbing perihelion rows and orbit conversion. Also lints a lot of unlinted files.
Also fixes a small bug in unit test for applying linking window (#1029) that wasn't caught - function returned before the rest of the unit test carried out. Didn't fail the unit test but wasn't completely being ran before.