Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First batch variable renaming. #880

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

astronomerritt
Copy link
Collaborator

Fixes #872.
Fixes #871.
Fixes #870.
Fixes #869.

  • First batch of renaming done: the above column names have been changed throughout the code and docstrings.
  • Pointing database SQL query has been changed everywhere to reflect the new column names.
  • All unit tests and unit test files have been changed to reflect the new column names.
  • Benchmark script files have been changed to reflect the new column names.
  • Goldens regenerated.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@astronomerritt
Copy link
Collaborator Author

Docs build is failing because I also need to edit the notebooks. One second.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (5e8a276) to head (6de92fd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #880   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files          68       68           
  Lines        3020     3020           
=======================================
  Hits         2411     2411           
  Misses        609      609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astronomerritt
Copy link
Collaborator Author

The docs build is failing because of the notebook demo_Lightcurve.ipynb. This notebook is erroring because sorcha-addons also needs to be changed. I have done so and submitted a PR here.

Copy link
Collaborator

@mschwamb mschwamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@mschwamb mschwamb merged commit 5098509 into dirac-institute:main Mar 25, 2024
6 of 8 checks passed
@astronomerritt astronomerritt deleted the variable_rename branch April 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants