Inline repeater interface fixes #251
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes accessibility and drag-and-drop issues in the inline repeater interface. It enhances focus styling for better accessibility compliance and resolves expansion state preservation during drag operations.
Key changes:
- Implemented drag-and-drop expansion state preservation logic
- Enhanced focus styling with proper CSS selectors and focus ring properties
- Updated package dependencies to newer versions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/inline-repeater-interface/src/list.vue | Added drag state tracking and expansion index updating logic, improved focus styling |
| packages/inline-repeater-interface/package.json | Bumped version and updated dependencies to newer versions |
| packages/inline-repeater-interface/CHANGELOG.md | Added changelog entries for the new version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| function onDragStart(evt: any) { | ||
| draggedItemIndex.value = evt.oldIndex; | ||
| isDragging.value = true; | ||
| } | ||
| function onDragEnd(evt: any) { |
There was a problem hiding this comment.
The event parameters should be properly typed instead of using any. Consider creating an interface or using the appropriate event type from the vuedraggable library.
Copilot uses AI. Check for mistakes.
| primary-key="+" | ||
| @update:model-value=" | ||
| (updatedElement) => { | ||
| (updatedElement: any) => { |
There was a problem hiding this comment.
The updatedElement parameter should be properly typed instead of using any. Consider using the appropriate type based on the expected data structure.
| (updatedElement: any) => { | |
| (updatedElement: Record<string, unknown>) => { |
Copilot uses AI. Check for mistakes.
| "@directus/types": "^13.0.0", | ||
| "@types/lodash": "^4.17.20", | ||
| "typescript": "^5.5.4" | ||
|
|
There was a problem hiding this comment.
There's an extra empty line before the closing brace. This should be removed to maintain consistent JSON formatting.
Copilot uses AI. Check for mistakes.
Improved
Fixed