Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV scroller buttons / shadows #120

Merged
merged 11 commits into from
Jan 25, 2024
Merged

TV scroller buttons / shadows #120

merged 11 commits into from
Jan 25, 2024

Conversation

phazonoverload
Copy link
Member

This PR introduces three changes to the category scrollers on the TV home:

  1. Shadows where there is overflow.
  2. Buttons to progress users left/right with scroll snap. Important for users without easy ability to horizontal scroll. Disabled and lower opacity when at left/right limit.
  3. Adding show count to category title

2024-01-23T1700 33

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for directus-website ready!

Name Link
🔨 Latest commit 8c72982
🔍 Latest deploy log https://app.netlify.com/sites/directus-website/deploys/65b28e7d7d21520007ff8611
😎 Deploy Preview https://deploy-preview-120--directus-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😍

Non-blocking: I was wondering whether we could find a way to make the actual title stand out a bit from the count, e.g. by making the count a sub header?

@phazonoverload phazonoverload merged commit 536398f into main Jan 25, 2024
6 checks passed
@phazonoverload phazonoverload deleted the tv/scroller-buttons branch January 25, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants