Multiple inspector panels can run side by side (#854)

GUI/Dialogs/Inspector/Inspector.swift

@@ -610,8 +610,10 @@ class Inspector: DialogController {
     override func showWindow(_ sender: Any?) {
 
         super.showWindow(self)
+
+        // Enter debug mode
         emu.trackOn()
-        updateInspectionTarget()
+        amiga.autoInspectionMask = 0xFF
     }
 
     override func awakeFromNib() {
@@ -781,13 +783,7 @@ class Inspector: DialogController {
             break
         }
     }
-
 
-    func showMessage(_ msg: String) {
-
-        message.stringValue = msg
-    }
-
     func scrollToPC() {
 
         if cpuInfo != nil {
@@ -839,14 +835,26 @@ extension Inspector {
 
         super.windowWillClose(notification)
 
-        // Leave debug mode
-        emu?.trackOff()
-        emu?.amiga.autoInspectionMask = 0
+        // Unregister the inspector
+        if let index = parent.inspectors.firstIndex(where: { $0 === self }) {
+
+            // print("Removing inspector at index \(parent.inspectors.count)")
+            parent.inspectors.remove(at: index)
+        }
+
+        // Leave debug mode if no more inspectors are open
+        if parent.inspectors.isEmpty {
+
+            // print("Leaving debug mode")
+            emu?.trackOff()
+            amiga.autoInspectionMask = 0
+        }
     }
 }
 
 extension Inspector: NSTabViewDelegate {
 
+    /*
     func updateInspectionTarget() {
 
         func mask(_ types: [CType]) -> Int {
@@ -878,11 +886,10 @@ extension Inspector: NSTabViewDelegate {
             fullRefresh()
         }
     }
+    */
 
     func tabView(_ tabView: NSTabView, didSelect tabViewItem: NSTabViewItem?) {
 
-        if tabView === panel {
-            updateInspectionTarget()
-        }
+        fullRefresh()
     }
 }

GUI/MyController.swift

@@ -33,7 +33,7 @@ class MyController: NSWindowController, MessageReceiver {
     var emu: EmulatorProxy!
 
     // Inspector panel of this emulator instance
-    var inspector: Inspector?
+    var inspectors: [Inspector] = []
 
     // Monitor panel of this emulator instance
     var monitor: Monitor?
@@ -282,7 +282,8 @@ extension MyController {
         if frames % 5 == 0 {
 
             // Animate the inspectors
-            if inspector?.window?.isVisible == true { inspector!.continuousRefresh() }
+            for inspector in inspectors { inspector.continuousRefresh() }
+            // if inspector?.window?.isVisible == true { inspector!.continuousRefresh() }
         }
 
         // Do less times...
@@ -368,8 +369,7 @@ extension MyController {
         var acceleration: Double { return Double(msg.value == 0 ? 1 : msg.value) }
 
         func passToInspector() {
-
-            inspector?.processMessage(msg)
+            for inspector in inspectors { inspector.processMessage(msg) }
         }
 
         // Only proceed if the proxy object is still alive

GUI/MyControllerMenu.swift

@@ -251,10 +251,18 @@ extension MyController: NSMenuItemValidation {
 
     @IBAction func inspectorAction(_ sender: Any!) {
 
-        if inspector == nil {
-            inspector = Inspector(with: self, nibName: "Inspector")
+        let count = inspectors.count
+
+        // Only allow 8 inspectors at a time
+        if count < 8, let inspector = Inspector(with: self, nibName: "Inspector") {
+
+            inspectors.append(inspector)
+            inspector.showWindow(self)
+
+        } else {
+
+            NSSound.beep();
         }
-        inspector?.showWindow(self)
     }
 
     @IBAction func monitorAction(_ sender: Any!) {

GUI/WindowDelegate.swift

@@ -61,9 +61,11 @@ extension MyController: NSWindowDelegate {
         debug(.shutdown, "Shut down the audio unit...")
         macAudio.shutDown()
 
-        debug(.shutdown, "Close the inspector...")
-        inspector?.close()
-        inspector?.join()
+        debug(.shutdown, "Close the inspectors...")
+        for inspector in inspectors {
+            inspector.close()
+            inspector.join()
+        }
 
         debug(.shutdown, "Close the monitor...")
         monitor?.close()