Add audio state transitions 2,3 -> 0 to disableDMA() #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling the audio DMA the state machine does not return to state 0. If audio DMA is reenabled the audio "latches" are then not read, because the state machine does not start from state 0. This causes missed sounds for play out.
The attached kick ROM shows two pink balls which when just out of sight invert their direction and play a sound on channel 0, otherwise "silence" is being played out. Without the change from time to time no sound can be heard. With the change the sound is always played out, there aren't any misses.
game.a.zip