-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for user's avatar decorations #2668
base: master
Are you sure you want to change the base?
Conversation
…oration avatar as ImageProxy
|
Do I use the same object present in User for adding support in Member? |
Yes, same object, but stored on the member, just like any member profile element that's also present on an user |
As |
@@ -293,6 +293,9 @@ default ImageProxy getAvatar() | |||
return avatarUrl == null ? null : new ImageProxy(avatarUrl); | |||
} | |||
|
|||
@Nullable | |||
User.AvatarDecoration getAvatarDecoration(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing docs
public class GuildMemberUpdateAvatarDecorationEvent extends GenericGuildMemberUpdateEvent<User.AvatarDecoration> { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public class GuildMemberUpdateAvatarDecorationEvent extends GenericGuildMemberUpdateEvent<User.AvatarDecoration> { | |
public class GuildMemberUpdateAvatarDecorationEvent extends GenericGuildMemberUpdateEvent<User.AvatarDecoration> | |
{ |
import net.dv8tion.jda.api.entities.Member; | ||
import net.dv8tion.jda.api.entities.User; | ||
import org.jetbrains.annotations.NotNull; | ||
import org.jetbrains.annotations.Nullable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use javax.annoations
instead
@@ -0,0 +1,58 @@ | |||
package net.dv8tion.jda.api.events.guild.member.update; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing copyright headers
@@ -0,0 +1,55 @@ | |||
package net.dv8tion.jda.api.events.user.update; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing copyright
/** | ||
* Represents the avatar decoration of a {@link User User}. | ||
*/ | ||
class AvatarDecoration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing equals() and hashCode(), since you rely on that for update checks.
@ItsTheSky what is the status here? |
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Adds support for the user's decoration avatar. Discord docs are outdated about the user's object, check this PR for the "updated" endpoints.