Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embed parameter for webhooks in SendMessageAsync #2893

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

akaJuliaan
Copy link
Contributor

Description

This PR adds a embed parameter to the SendMessageAsync method for Webhooks, like it is already in the SendMessageAsync method for Channels.

Changes

  • Add embed parameter
  • Update Webhook sample

@akaJuliaan
Copy link
Contributor Author

The build for the samples logically fails because the new parameter does not yet exist in version 3.13.1 which they are referring to.

@SylveonDeko
Copy link
Contributor

Embed parameter is not needed as you can pass a single embed in an embed array into the embeds parameter. Yes it's inconvenient but redundant parameters aren't useful

@akaJuliaan
Copy link
Contributor Author

If redundant parameters are unwanted, why is there the exactly same embed parameter for the channels?

@SylveonDeko
Copy link
Contributor

SylveonDeko commented Mar 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants