-
-
Notifications
You must be signed in to change notification settings - Fork 745
[Feature] Component Designer #3185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
quinchs
wants to merge
17
commits into
dev
Choose a base branch
from
feat/component-designer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a 'html' like way to design and build components, specifically v2 components, providing design-time error analysis based off of the constraints of the Discord API.
Currently, the support is pretty basic, only allowing discords defined components, but in the future this could be expanded apon to create stateful and custom components.
Blockers
Performance
The custom XML parser is a one-and-done full parser, and could be greatly improved with incremental parsing, given the source tree from the C# generator. This would greatly speed up the parsing of the CXML.
As of right now, after the parse step, the entire component node tree is regenerated, which again could benefit from incremental mutations
Testing
There are no tests for any of this, and that smells, some good tests for parsing, diagnostic reporting, and so on are needed.
Future prospects
As mentioned earlier, the possibilities with this feature can extend out to a full dom-like renderer and state manager, making stateful cards super trivial to implement:
The possibilities are quite literally endless with this.
Custom IDE language plugin
It would also be trivial to implement a custom LSP for the components, and provide both VS, VSC, and jetbrains plugins to support them in the
StringSyntax
attribute used for the basic highlighting in the CXML strings