PHP 8.4: Implicitly nullable parameters deprecated

discord-php · Nov 21, 2024 · 0a76a35 · 0a76a35
1 parent 562cb8a
commit 0a76a35
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/Discord/Helpers/RegisteredCommand.php b/src/Discord/Helpers/RegisteredCommand.php
@@ -168,14 +168,14 @@ public function getSubCommand(string $name): ?RegisteredCommand
      * Adds a sub-command to the command.
      *
      * @param string|array  $name
-     * @param callable      $callback
+     * @param callable|null $callback
      * @param callable|null $autocomplete_callback
      *
      * @throws \LogicException
      *
      * @return static
      */
-    public function addSubCommand($name, callable $callback = null, ?callable $autocomplete_callback = null): RegisteredCommand
+    public function addSubCommand($name, ?callable $callback = null, ?callable $autocomplete_callback = null): RegisteredCommand
     {
         if (is_array($name) && count($name) == 1) {
             $name = array_shift($name);

diff --git a/src/Discord/Parts/Channel/Channel.php b/src/Discord/Parts/Channel/Channel.php
@@ -982,7 +982,7 @@ protected function getDefaultReactionEmojiAttribute(): ?Reaction
      *
      * @since 10.0.0 Arguments for `$name`, `$private` and `$auto_archive_duration` are now inside `$options`
      */
-    public function startThread(array|string $options, string|null|bool $reason = null, int $_auto_archive_duration = 1440, ?string $_reason = null): PromiseInterface
+    public function startThread(array|string $options, string|bool|null $reason = null, int $_auto_archive_duration = 1440, ?string $_reason = null): PromiseInterface
     {
         // Old v7 signature
         if (is_string($options)) {

diff --git a/src/Discord/Repository/Guild/MemberRepository.php b/src/Discord/Repository/Guild/MemberRepository.php
@@ -68,7 +68,7 @@ public function kick(Member $member, ?string $reason = null): PromiseInterface
      *
      * @param array $queryparams Query string params to add to the request, leave null to paginate all members (Warning: Be careful to use this on very large guild)
      */
-    public function freshen(array $queryparams = null): PromiseInterface
+    public function freshen(?array $queryparams = null): PromiseInterface
     {
         if (isset($queryparams)) {
             return parent::freshen($queryparams);

diff --git a/tests/functions.php b/tests/functions.php
@@ -16,7 +16,7 @@
 
 const TIMEOUT = 10;
 
-function wait(callable $callback, float $timeout = TIMEOUT, callable $timeoutFn = null)
+function wait(callable $callback, float $timeout = TIMEOUT, ?callable $timeoutFn = null)
 {
     $discord = DiscordSingleton::get();