Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add per-category blocked roles-list #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itzwam
Copy link

@itzwam itzwam commented Oct 22, 2023

Versioning information

  • This includes major changes (breaking changes)
  • This includes minor changes (minimal usage changes, minor new features)
  • This includes patches (bug fixes)
  • This does not change functionality at all (code refactoring, comments)

Is this related to an issue?

Changes made

Added per-category roles blocklist

Confirmations

  • I have updated related documentation (if necessary)
  • My changes use consistent code style
  • My changes have been tested and confirmed to work

@eartharoid
Copy link
Member

@itzwam how would you use this feature?
The uses I'm thinking of can be fulfilled by required roles.

@itzwam
Copy link
Author

itzwam commented May 7, 2024

Late reply cuz I didn't see your message,

on my side there are some ticketing categories that are allowed for all roles
except a specific one, and I would try to avoid allowing manually all roles for the evolutivity of the solution

let's say I create 12 roles on my server, I dont want to update the allowed-list with every-roles-but-one, instead I'prefer to specify a blocked role and it works perfectly

that's a workflow I already use locally and I would like to upstream this change to the bot cuz I don't think I'm the only one who needs it

@itzwam
Copy link
Author

itzwam commented May 13, 2024

Just figured-out the DB migrations I edited aren't the good ones, think I will need to create new schema migrations files for this specific upgrade, but not sure how to do it properly

it "worked" like that but pretty sure I'm not supposed to edit old schema migration scripts.

Copy link
Member

@eartharoid eartharoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the SQL files should be reverted.
The process for generating new migrations is to use primsa migrate dev for each of the providers.

@eartharoid eartharoid marked this pull request as ready for review May 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants