-
Notifications
You must be signed in to change notification settings - Fork 71
App group lifecycle plugin #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
barborico
wants to merge
15
commits into
main
Choose a base branch
from
brynna/app_group_lifecycle_plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,219
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f28e5c to
d2a61a0
Compare
0a0aebe to
0b8c460
Compare
…rving current DB session commit groupings.
…ith hook invocations for plugin-specific config validation.
…fecycle plugins to power frontend components writing config and reading config and status for plugins.
… dev to reduce log noise.
0b8c460 to
23f866d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR introduces a new type of Access plugin called an "app group lifecycle plugin." Such plugins support managing downstream applications based on Access app group existence and membership. This facilitates a light SCIM implementation where downstream apps' support for Okta SCIM is lacking.
Our team has already envisioned three use cases for such a plugin:
UI Screenshots
Create app
Update app
Create app group
View app
Update app group
View app group
Reviewing
There's a lot of code here (thanks, Claude!), so I strongly recommend going commit-by-commit for logically-grouped changes. This is also a substantial enough feature that I'd encourage reviewers to try it themselves in local dev.
Testing
Unit Tests
All of the plugin spec's public functions have unit tests. Run them via:
tox -e test -- tests/test_app_group_lifecycle_plugin.pyE2E Testing
I've installed the example plugin and run the app locally to play around with the UX pretty extensively.