Update to Statix 1.2.1 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for compatibility with newer ERTS releases lexmag/statix#42. We should also look into maybe using bleacherreport's fork as I'm not a fan of calling Port.command directly instead of using `:gen_udp.send`
|
@samschlegel I'm fine with updating this dependency. Switching to https://github.com/bleacherreport/statix doesn't seem to address the concern you raised, it appears that they are also just doing direct |
|
Yeah, that change is only on this branch iirc https://github.com/bleacherreport/statix/tree/otp-21.3.8.4-support Looking forward to this update! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for compatibility with newer ERTS releases
(related issue: lexmag/statix#42)
We should also look into maybe using https://github.com/bleacherreport/statix as I'm not a fan of how
https://github.com/lexmag/statixcallsPort.command/2directly instead of using:gen_udp.send/4. It leads to a lot of custom code that will constantly be chasing releases as it's using an internal API