Skip to content

perf: batch updates to sync to react #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 3.19.3-discord
Choose a base branch
from
Draft

perf: batch updates to sync to react #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions packages/react-native-reanimated/src/updateProps/updateProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import { isFabric, isJest, shouldBeUseWeb } from '../PlatformChecker';
import type { ReanimatedHTMLElement } from '../ReanimatedModule/js-reanimated';
import { _updatePropsJS } from '../ReanimatedModule/js-reanimated';
import { runOnJS, runOnUIImmediately } from '../threads';
import { processTransformOrigin } from './processTransformOrigin';
import { ComponentRegistry } from './ComponentRegistry';
import { processTransformOrigin } from './processTransformOrigin';

let updateProps: (
viewDescriptors: ViewDescriptorsWrapper,
Expand Down Expand Up @@ -76,15 +76,31 @@ export const updatePropsJestWrapper = (

export default updateProps;

// Apply thr changes from UI thread to JS thread.Add commentMore actions
let updatesToReactJS: { [tag: string]: StyleProps } = {};

function flushUpdatesToReactJS() {
Object.keys(updatesToReactJS).forEach((tagStr) => {
const tag = Number(tagStr);
const props = updatesToReactJS[tag];
const component = ComponentRegistry.getComponent(tag);
if (component) {
component._updateReanimatedProps(props);
}
})
updatesToReactJS = {}
}

let timeoutId: NodeJS.Timeout | undefined;
// Apply the changes from UI thread to JS thread.
function updatePropsOnReactJS(tag: number, props: StyleProps) {
const component = ComponentRegistry.getComponent(tag);
if (component) {
component._updateReanimatedProps(props);
updatesToReactJS[tag] = {
...updatesToReactJS[tag],
...props,
}
clearTimeout(timeoutId);
timeoutId = setTimeout(flushUpdatesToReactJS, 0) ;
}


const createUpdatePropsManager = isFabric()
? () => {
'worklet';
Expand Down
Loading