Skip to content

Toggle the new Android prop diffing mechanism for components (0.78.2) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fabOnReact
Copy link

@fabOnReact fabOnReact commented May 27, 2025

Summary:

The PR for branch 0.78.0 is #69.

The feature flag is supported in react-native 0.79 and requires cherrypicking the following commits from David Vacca:

  • Implement prop diffing for accessibility props in View #48833
  • Implement prop diffing for transform props in View #48832
  • Implement prop diffing for border props in View #48831
  • Implement prop diffing for event props in View #48830
  • Implement prop diffing for basic props in View #48829

Enables feature flag enablePropsUpdateReconciliationAndroid to fix https://app.asana.com/1/236888843494340/project/1199705967702853/task/1209601835367711?focus=true

More info at facebook#45551 and https://github.com/discord/react-native/blob/e0702345591cb461e196aabd8be0bf51839a2df3/packages/react-native/scripts/featureflags/README.md

Changelog:

This diffs toggles the new Android prop diffing mechanism for components

Test Plan:

Regressions from previous PR #61 are fixed by cherry picking the above commits.

Branch 0.78:

Before enabling the feature flag After enabling the feature flag

After cherry-picking commits:

Discord:

Before cherry-pick After cherry-pick
20250527_202152.mp4
20250527_202926.mp4

@fabOnReact fabOnReact marked this pull request as ready for review May 27, 2025 11:15
@fabOnReact fabOnReact marked this pull request as draft May 27, 2025 11:30
@fabOnReact fabOnReact marked this pull request as ready for review May 27, 2025 11:40
@fabOnReact
Copy link
Author

fabOnReact commented May 27, 2025

closed in favour of #69

@fabOnReact fabOnReact marked this pull request as draft May 27, 2025 12:22
@fabOnReact fabOnReact changed the title Toggle the new Android prop diffing mechanism for components Toggle the new Android prop diffing mechanism for components (0.78.2) May 27, 2025
@fabOnReact fabOnReact closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant