Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactions): add launchActivity method #10646

Merged
merged 16 commits into from
Jan 24, 2025

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Dec 8, 2024

Please describe the changes this PR makes and why it should be merged:
#10640 but for core

Depends on

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 9:06am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 9:06am

packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.01%. Comparing base (3d85d96) to head (d1bc152).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10646   +/-   ##
=======================================
  Coverage   38.01%   38.01%           
=======================================
  Files         239      239           
  Lines       14893    14893           
  Branches     1392     1392           
=======================================
  Hits         5661     5661           
  Misses       9220     9220           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imnaiyar and others added 2 commits January 3, 2025 19:05
Co-authored-by: Jiralite <[email protected]>
Co-authored-by: Jiralite <[email protected]>
@imnaiyar imnaiyar requested a review from Jiralite January 3, 2025 13:06
@kodiakhq kodiakhq bot merged commit a3fa1a8 into discordjs:main Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants