Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print out support for aes-256-gcm in native node:crypto #10764

Merged

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Just some extra debug info for voice users to make sure their encryption will work without anything optional installed

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vladfrangu vladfrangu requested a review from a team as a code owner February 19, 2025 18:12
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Feb 19, 2025 6:12pm
discord-js-guide ⬜️ Ignored (Inspect) Feb 19, 2025 6:12pm

@Jiralite Jiralite added this to the voice 0.19.0 milestone Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.67%. Comparing base (4b63bb8) to head (84702a2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/voice/src/util/generateDependencyReport.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10764      +/-   ##
==========================================
- Coverage   38.67%   38.67%   -0.01%     
==========================================
  Files         239      239              
  Lines       14653    14654       +1     
  Branches     1385     1385              
==========================================
  Hits         5667     5667              
- Misses       8974     8975       +1     
  Partials       12       12              
Flag Coverage Δ
voice 69.95% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 19d48f6 into main Feb 19, 2025
25 checks passed
@kodiakhq kodiakhq bot deleted the voice/print-native-crypto-support-for-aes-in-debug-info branch February 19, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants