DEV: Scope topic voting tables to avoid confusion with post voting #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
migrate-table
branch
2 times, most recently
from
d23608e to
ab8df50
Compare
tyb-talks
reviewed
Jul 15, 2024
tyb-talks
reviewed
Jul 15, 2024
We're not using OnceOffs any more, so to avoid having to maintain this, we're moving it to a migration. This post migration should ideally be a no-op, so it is fine to run anyway
CREATE TABLE LIKE INCLUDING ALL actually creates an index as well, so there is no need to create an index again. It is probably also better to set the nextval of a seq than to change ownership from one table to another.
tyb-talks
approved these changes
Jul 17, 2024
nlalonde
added a commit
to discourse/discourse
that referenced
this pull request
Jul 29, 2024
discourse/discourse-topic-voting#196 Some tables in that plugin are read-only, so the script fails when trying to update rows in those tables. Add them to the ignore list.
nlalonde
added a commit
to discourse/discourse
that referenced
this pull request
Jul 29, 2024
discourse/discourse-topic-voting#196 Some tables in that plugin are read-only, so the script fails when trying to update rows in those tables. Add them to the ignore list.
gschlager
pushed a commit
to discourse/discourse
that referenced
this pull request
Aug 1, 2024
discourse/discourse-topic-voting#196 Some tables in that plugin are read-only, so the script fails when trying to update rows in those tables. Add them to the ignore list.
This was referenced Aug 2, 2024
nattsw
added a commit
that referenced
this pull request
Aug 7, 2024
There was a typo here - #196 - that unfortunately went through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
discourse_votingtotopic_votingsince there are two forms of voting in Discourse - posts and topics.This PR also moves a OnceOff into a post migration. The post migration will be executed, but should ideally be a no-op. This allows us to not have to maintain the OnceOff as it had to be modified before with a previous migration. I considered removing this file altogether, but I don't think there is anything negative from just converting it into a migration, and it might be useful in the unlikely scenario that a forum from the past has never ran the OnceOff before.