Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Indicate source and target languages in error prompt #185

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

nattsw
Copy link
Contributor

@nattsw nattsw commented Nov 29, 2024

When translation fails, the error is shown as such.

Screenshot 2024-11-29 at 11 07 20 PM

There are certain cases when it is not obvious what a user's locale is, and it is hard to provide support to new language pairs when this happens. This PR adds the source and target language of the user to the error message for better diagnostics.

Screenshot 2024-11-29 at 11 13 53 PM

config/locales/server.en.yml Outdated Show resolved Hide resolved
@nattsw nattsw merged commit 094ffeb into main Dec 2, 2024
3 checks passed
@nattsw nattsw deleted the show-source-target-error branch December 2, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants