FEATURE: Show experimental language switcher for anon users #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
language-selector
branch
from
32ee6ba to
9dc24a4
Compare
nattsw
added a commit
to discourse/discourse
that referenced
this pull request
Jan 23, 2025
…ions (#30924) Related: discourse/discourse-translator#198 The new experimental feature on discourse-translator requires this `SiteSetting.set_locale_from_cookie` to be set. This comment unhides the existing site setting.
nattsw
changed the title
lis2
approved these changes
Jan 24, 2025
nattsw
commented
Jan 24, 2025
| position: "first", | ||
| className: state.isTranslated ? "translated" : null, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Oh yikes! It's not perfect, this was accidentally removed. Will add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows anon users to select a language using a language switcher, this feature is behind an experimental site setting
experimental_anon_language_switcher. The set of languages are defined by the same one available to existing users of the site, with the requiredallow_user_localesetting turned on:https://github.com/discourse/discourse/blob/de7e213052c850aab0258131c47da777ec679621/app/models/locale_site_setting.rb#L37-L50
In the near future, we may consider shortening this list of languages, and will also expand this feature into user-contributed content.
anon-switch.copy.mp4