Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDST-758] update workflows to their reusable versions #151

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

JojoVes
Copy link
Contributor

@JojoVes JojoVes commented Nov 14, 2024

noticed errors in the linting workflow for #150, so I copied the more recent lint and semver workflows found in other repos that seem to be working (for example: https://github.com/discoverygarden/dgi_i8_helper/commit/bbaea261fe6c29d2534aadcec47a5b4ec88ec1b4#diff-248962e0d8d239ef3392f051ef2a689de195994852d4b555ff20b7a30f2414d0R2)

@JojoVes JojoVes added the patch Backwards compatible bug fixes. label Nov 14, 2024
@nchiasson-dgi
Copy link
Contributor

Looks good! Reviewed the workflow record to ensure that nothing new was occurring in relation to the PR, the Code Linting complaints are from existing formatting within the module that hasn't been cleaned up and can be temporarily ignored, but maybe should be cleaned up eventually.

@nchiasson-dgi nchiasson-dgi added no-update No tag/release needs to be created and removed patch Backwards compatible bug fixes. labels Nov 14, 2024
@nchiasson-dgi nchiasson-dgi merged commit ada58d0 into main Nov 14, 2024
1 check failed
@nchiasson-dgi nchiasson-dgi deleted the DDST-758-update-workflows branch November 14, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-update No tag/release needs to be created
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants