Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUCIR-199: Some genericizing. #37

Merged
merged 29 commits into from
May 9, 2024
Merged

AUCIR-199: Some genericizing. #37

merged 29 commits into from
May 9, 2024

Conversation

adam-vessey
Copy link
Contributor

@adam-vessey adam-vessey commented Apr 3, 2024 •
edited
Loading

@adam-vessey adam-vessey added the minor Added functionality that is backwards compatible. label Apr 3, 2024
adam-vessey added 25 commits April 3, 2024 13:20
@adam-vessey
Drop extra newline.
2f2d43d
@adam-vessey
Add return typehints.
3ffce3d
@adam-vessey
Can also be null.
8bcda95
@adam-vessey
Relay index tracking down to files, as necessary.
b744925
@adam-vessey
Adjust media_type loading.
787ae75
@adam-vessey
Fix up intersection.
de3eb89
@adam-vessey
Move to use Solr joins instead.
209c7ce
@adam-vessey
Rework over to make use of joins.
2360edb
@adam-vessey
Rework tracker logic slightly.
7e8d650
@adam-vessey
Coding standards.
dd17601
@adam-vessey
Merge branch 'feature/better-caching' into feature/generalize
1e5dddc
@adam-vessey
Fix up the direction of multiplicity with the values.
039969e
@adam-vessey
Add in the fix to the old processor.
26e0b90
@adam-vessey
Attempt to soften the dependency.
7b226fd
@adam-vessey
Move calculation of current IP ranges.
87f1cbd
@adam-vessey
Pull "info" apart to separate settings.
f89a4c9
@adam-vessey
Adjustments.
3d11969
@adam-vessey
Carry-through more of constant use.
1e2a77c
@adam-vessey
Pull the conditions we need to alter to deal with collections out.
49ac2b0 
Should facilitate altering them to add additional conditions.

... the question now: Move to event dispatch to build?
@adam-vessey
Move over to event handling.
a323d51
@adam-vessey
Drop extra newline.
e036ba6
@adam-vessey
Add something of a comment.
ad63a22
@adam-vessey
Slight refactor.
f29f33f 
Allow overriding of entity setup, looking to move embargoes set up the
tree.
@adam-vessey
Document our processors.
8a4783e
@adam-vessey
Bit more docs.
3c3f984
@adam-vessey adam-vessey marked this pull request as ready for review April 12, 2024 13:43
@adam-vessey adam-vessey mentioned this pull request Apr 15, 2024
Merged
@adam-vessey
Add explicit return of null.
6aaa639 
Apparently, the implicit return of null breaks the typehint?
@nchiasson-dgi nchiasson-dgi merged commit b54b44a into main May 9, 2024
4 checks passed
@nchiasson-dgi nchiasson-dgi deleted the feature/generalize branch May 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor Added functionality that is backwards compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-vessey @nchiasson-dgi