DDST-785: Working with remote wrappers

.github/workflows/lint.yml

@@ -1,3 +1,4 @@
+---
 name: Code Linting
 on:
   pull_request:
@@ -7,9 +8,4 @@ on:
 
 jobs:
   Lint:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout Repo
-        uses: actions/checkout@v3
-      - name: Run CodeSniffer
-        uses: discoverygarden/CodeSniffer@v1
+    uses: discoverygarden/CodeSniffer/.github/workflows/lint.yml@v1

src/Plugin/migrate/source/Foxml.php

@@ -4,11 +4,9 @@
 
 use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
 use Drupal\Core\StringTranslation\StringTranslationTrait;
-
 use Drupal\foxml\Utility\Fedora3\ObjectLowLevelAdapterInterface;
-use Drupal\migrate\Plugin\migrate\source\SourcePluginBase;
 use Drupal\migrate\Plugin\MigrationInterface;
-
+use Drupal\migrate\Plugin\migrate\source\SourcePluginBase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**
@@ -38,7 +36,7 @@ public function __construct(
     $plugin_id,
     $plugin_definition,
     MigrationInterface $migration,
-    ObjectLowLevelAdapterInterface $object_storage
+    ObjectLowLevelAdapterInterface $object_storage,
   ) {
     $this->objectStorage = $object_storage;
     parent::__construct($configuration, $plugin_id, $plugin_definition, $migration);
@@ -52,7 +50,7 @@ public static function create(
     array $configuration,
     $plugin_id,
     $plugin_definition,
-    MigrationInterface $migration = NULL
+    ?MigrationInterface $migration = NULL,
   ) {
     // Allow a specific storage to be targeted.
     $object_service_name = $configuration['object_service_name'] ?? 'foxml.parser.object_lowlevel_storage';

src/StreamWrapper/Foxml.php

@@ -96,8 +96,8 @@ protected function getLocalPath($uri = NULL) {
     $realpath = $this->fileSystem->realpath($path);
     if (!$realpath) {
 
-      // This file does not yet exist.
-      $realpath = $this->fileSystem->realpath(dirname($path)) . '/' .
+      // This file does not yet exist, or $path references something remote.
+      $realpath = $this->fileSystem->dirname($path) . '/' .
         $this->fileSystem->basename($path);
     }
 

src/Utility/Fedora3/Element/DigitalObject.php

@@ -218,10 +218,12 @@ public function models() {
    * @return string[]
    *   The collection parents of the given object.
    */
-  public function parents(array $predicates = [
-    'isMemberOf',
-    'isMemberOfCollection',
-  ]) {
+  public function parents(
+    array $predicates = [
+      'isMemberOf',
+      'isMemberOfCollection',
+    ],
+  ) {
     assert(count($predicates) > 0, 'Has at least one predicate for which to look.');
     $map = function ($pred) {
       return "self::fre:$pred";

src/Utility/Fedora3/FoxmlParser.php

@@ -86,7 +86,7 @@ class FoxmlParser extends AbstractParser {
   public function __construct(
     CacheBackendInterface $cache,
     LowLevelAdapterInterface $datastream_storage,
-    LockBackendInterface $lock
+    LockBackendInterface $lock,
   ) {
     $this->cache = $cache;
     $this->datastreamStorage = $datastream_storage;

src/Utility/Fedora3/ObjectLowLevelAdapterManager.php

@@ -21,7 +21,7 @@ class ObjectLowLevelAdapterManager extends AbstractLowLevelAdapterManager implem
    * Constructor.
    */
   public function __construct(
-    LoggerInterface $logger
+    LoggerInterface $logger,
   ) {
     $this->logger = $logger;
   }