Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning if the local application exits early #35

Merged
merged 1 commit into from
May 2, 2024

Conversation

chriso
Copy link
Contributor

@chriso chriso commented May 2, 2024

We expect the local application to be a long-running server. If it exits early, it indicates a problem. We now dump the logs and print an error message in this case.

This can happen, for example, if the user is using the FastAPI integration, but runs their entry point script with python rather than an ASGI server like uvicorn.

@chriso chriso self-assigned this May 2, 2024
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎬

@chriso chriso merged commit a05432a into main May 2, 2024
2 checks passed
@chriso chriso deleted the early-exit-warning branch May 2, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants