Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tui: color fixes #41

Merged
merged 4 commits into from
May 6, 2024
Merged

tui: color fixes #41

merged 4 commits into from
May 6, 2024

Conversation

chriso
Copy link
Contributor

@chriso chriso commented May 5, 2024

This PR fixes a few issues with colors:

  • we avoid using white, in case the user has a light/white background, instead using lipgloss.NoColor which is presumably white or black depending on the theme/background
  • we use ANSI(256) colors now, and use a slightly darker shade of green/yellow/red that looks better on light and dark background
  • we use lipgloss to style the log prefixes, and avoid manually parsing color related environment variables (which lipgloss does for us)

This fixes #31.

@chriso chriso self-assigned this May 5, 2024
@chriso chriso merged commit 39e40c1 into main May 6, 2024
2 checks passed
@chriso chriso deleted the color-fix branch May 6, 2024 00:39
@chriso chriso changed the title Color fixes tui: color fixes May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ANSI colors in the TUI
2 participants