Errors() +performance : using strings.Builder instead of string concatenation

[manisharma]

Proposing to use strings.Builder in place of string concatenation, in battery.Error() - following are the results -

╭─[email protected] ~/workspace/battery  ‹master› 
╰─➤  go test -bench=. -benchtime 2s -count 1 -benchmem -cpu 4 -run notest
goos: darwin
goarch: arm64
pkg: github.com/distatus/battery
BenchmarkErrors_Error-4                 14642497               147.5 ns/op            64 B/op          6 allocs/op
BenchmarkErrors_ErrorBuilder-4          37910373                63.16 ns/op           24 B/op          2 allocs/op
PASS
ok      github.com/distatus/battery     4.896s

[KenjiTakahashi]

Thanks, makes perfect sense to change that. The strings.Builder didn't exist back when I was writing this code.

No need to include 2 versions and benchmarks, though, we're not a strings building library ;-). Just change the old implementation to the new one.

[manisharma]

Thanks, makes perfect sense to change that. The strings.Builder didn't exist back when I was writing this code.

No need to include 2 versions and benchmarks, though, we're not a strings building library ;-). Just change the old implementation to the new one.

Done, thanks!

[KenjiTakahashi]

Now it has the same problem with nil at the beginning ;-].
You cannot rely on indexes when you're also filtering at the same time.
Think the way to solve it here is to check s.Len() > 1. Shouldn't add much to the time, as the Len call is effectively O(1).

[KenjiTakahashi]

I suppose that WriteByte(' ') would be somewhat faster?