consolidate http request handling, and use api urls fresh every time #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api urls were loaded into each manager's httpclient in the constructors. this resulted in tweaks to the urls not actually changing which url was used, until the plugin is reloaded. this also introduced a problem where if the url is invalid, then the plugin will fail to load outright, and the user will have to manually edit save data to fix the url. so obviously both of those things suck XD
|
tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api urls were loaded into each manager's httpclient in the constructors. this resulted in tweaks to the urls not actually changing which url was used, until the plugin is reloaded. this also introduced a problem where if the url is invalid, then the plugin will fail to load outright, and the user will have to manually edit save data to fix the url. so obviously both of those things suck XD