Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill offer bugfixes #749

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fill offer bugfixes #749

wants to merge 2 commits into from

Conversation

cryptonautical
Copy link
Contributor

Technical Description

bugfixes for issues described #748 and #746

PR Checklist

  • Has the pr been tested manually by at least 1 reviewer?
  • Has all feedback been addressed?
  • Are all tests and linters running without error?

Screenshots / Screen-recordings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow offer expiry > pool expiry in Create offer [Bug] Wrong collateral token in Fill Offer
1 participant