Fix 0x orders refresh #805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CreateOrder.tsx`
|
Github deployment failed. It's most likely due to a merge conflict, but could also be because the code build failed, or something else... Go to dappling.network to view the preview build and logs. Please reach out if you get stuck - we're here to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
The trading page was accessing wrong 0x orders from the Redux stores when the user navigated from a market with existing orders to a market without orders via a trade page link. This resulted in wrong calculations for expected rate and Remaining allowance for the newly opened market.
This PR fixes this by requesting fresh orders from the 0x server.