Add support for P-384 and P-521, prepare new version #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upgrading the wasm-pack NPM dependency indeed fixed this. |
|
FWIW, the existing test vector test is now automatically testing the P-521 KEM, but no test vectors for P-384 were provided with the spec. |
tgeoghegan
approved these changes
Jul 10, 2024
branlwyd
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upgrade to
hpke0.12.0 recently landed. This bumps package versions, adds the ability to select the newly supported P-521, and does the same for P-384 as well.After applying these changes, I am now running into something like WebAssembly/binaryen#6608. Running
npm run buildhits a segfault in wasm-opt, but if I re-run the command adding the--debugflag, it works. (~/.cache/.wasm-pack/wasm-opt-4d7a65327e9363b7/wasm-opt pkg/node/hpke_dispatch_bg.wasm -o pkg/node/hpke_dispatch_bg.wasm-opt.wasm -O --debug) This will need some sort of upgrade or workaround before we can actually release this.