Rename provision_task to janus_cli, add create-datastore-key command.
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing is done via a new library used to spin up an ephemeral Kubernetes cluster using `kind`. It interacts with `kind` by shelling out; I'm not happy about this, but I can't find an equivalent library for Rust.
Unfortunately, kube doesn't work with rustls when talking to local clusters: kube-rs/kube#153 Thankfully, openssl is only a dependency if the test-utils feature is enabled, so our release builds will not depend on openssl. Unfortunately, that means that our release builds will be interacting with Kubernetes using a different TLS library than our tests use.
It's no longer necessary since the crate features are set up to (rightfully) not include openssl in release builds.
branlwyd
changed the title
provision_task to janus_cli, add create-datastore-key command.
|
(I suppose an obvious side-effect of this PR is that we'll now need to have |
divergentdave
approved these changes
Jul 15, 2022
tgeoghegan
approved these changes
Jul 15, 2022
Also, update a stale reference to "PPM" as the protocol name to "DAP".
|
Updated the README to note the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to provision a datastore key for new environments.
A few notes:
kubernetes::EphemeralClustertype that turns up a cluster on creation & turns it back down once the value is dropped. This is implemented by shelling out tokind; I'm not too happy about shelling out, but I can't find an equivalent Rust library, and I suppose it's somewhat more acceptable in test code.create-datastore-keydoesn't need a datastore to exist at all, yet it must receive datastore config information, including (bogus) datastore keys. If we want to clean this up, I would recommend dropping thejanus_mainabstraction, and moving the different things thatjanus_maindoes into helper functions that each binary can call as-needed. I'm going to leave this for a later PR, however.