Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/airqualityobserved #20

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Feature/airqualityobserved #20

wants to merge 23 commits into from

Conversation

shestyf
Copy link
Contributor

@shestyf shestyf commented Oct 21, 2022 •
edited
Loading

fix

@shestyf shestyf requested a review from istyf October 21, 2022 14:26
@shestyf shestyf changed the base branch from main to develop October 21, 2022 14:26
istyf
istyf requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@istyf istyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. We also need to consider how we deal with temporal data here ...

internal/pkg/application/services/airquality/airqualitysvc.go Show resolved Hide resolved
internal/pkg/application/services/airquality/airqualitysvc.go Outdated Show resolved Hide resolved
internal/pkg/application/services/airquality/airqualitysvc.go Outdated Show resolved Hide resolved
internal/pkg/application/services/airquality/airqualitysvc.go Outdated Show resolved Hide resolved
internal/pkg/presentation/api.go Outdated Show resolved Hide resolved
internal/pkg/application/services/airquality/airqualitysvc.go Outdated Show resolved Hide resolved
@shestyf shestyf mentioned this pull request Feb 7, 2023
Closed
2 tasks
istyf
istyf requested changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@istyf istyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du tappar bort mätvärdena på AQO och saknar mappers för dessa, vilket gör att det bara verkar gå att få reda på var vi mätt och när, men inte vad.

internal/pkg/application/services/airquality/airqualitysvc.go Outdated Show resolved Hide resolved
internal/pkg/application/services/airquality/airqualitysvc.go Show resolved Hide resolved
internal/pkg/presentation/handlers/airquality.go Outdated Show resolved Hide resolved
internal/pkg/presentation/handlers/airquality.go Outdated Show resolved Hide resolved
internal/pkg/presentation/handlers/airquality.go Show resolved Hide resolved
internal/pkg/presentation/api.go Outdated Show resolved Hide resolved
internal/pkg/presentation/handlers/airquality.go Show resolved Hide resolved
internal/pkg/application/services/airquality/airqualitysvc.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istyf istyf istyf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shestyf @istyf @nordbergmikael