Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BlendFactor documentation. #22

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Add BlendFactor documentation. #22

merged 3 commits into from
Sep 12, 2022

Conversation

dj2
Copy link
Owner

@dj2 dj2 commented Sep 10, 2022

This CL adds documentation for the blend factor enum values.

Issue #20

@dj2
Style and linking cleanup for API documentation.
7144195 
This CL updates the API document styles. The header links are also
updated to work a bit better, each method has a header ID which can be
used to link from other parts of the text.

Issue #10
@dj2
Add BlendFactor documentation.
980c29d 
This CL adds documentation for the blend factor enum values.

Issue #20
@dj2
Add substitute for method names
e34d5ff
@dj2 dj2 added the documentation Improvements or additions to documentation label Sep 10, 2022
@dj2 dj2 requested a review from Kangz September 10, 2022 18:03
@dj2 dj2 self-assigned this Sep 10, 2022
@dj2
Copy link
Owner Author

dj2 commented Sep 10, 2022

Note, this requires #21 to land first.

dj2
dj2 commented Sep 10, 2022
View reviewed changes
src/api.yaml
`(A_src, A_src, A_src, A_src)`
src alpha saturated: >
Factor is set to the source alpha value. <br>
`(A_src, A_src, A_src, A_src)`
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seemed weird to me as it's the same as src alpha. I filed gpuweb/gpuweb#3432 to determine the difference between the two.

@dj2 dj2 mentioned this pull request Sep 10, 2022
Merged
Base automatically changed from headers to main September 12, 2022 14:18
@dj2 dj2 merged commit a13ff36 into main Sep 12, 2022
@dj2 dj2 deleted the blend_factor branch September 12, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kangz Kangz Kangz approved these changes

Assignees

@dj2 dj2

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dj2 @Kangz