This repository has been archived by the owner on Aug 22, 2024. It is now read-only.
feat: clean undisplayable glyphs #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
changed the title
test_sign_function_call_string_with_newline (nanos passes, 2 others panic)
dj8yfo
force-pushed
the
newlines_review_hide
branch
from
6e86094 to
5175dd6
Compare
added 2 commits
March 20, 2024 19:15
dj8yfo
force-pushed
the
newlines_review_hide
branch
from
fc13a04 to
5f13556
Compare
|
commit c27b2c7 adds workaround for LedgerHQ/ledger-device-rust-sdk#124 |
frol
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr works around LedgerHQ/ledger-device-rust-sdk#146 and LedgerHQ/ledger-device-rust-sdk#124
DEL0x7f glyph is a nice square, it's used as a substitution character for undisplayable ascii control characters 0x00 - 0x1f2.1. see diff in speculos
2.2. it's consistent with behaviour on device without
hidden part ofchunk disappearingDEL0x7f glyph is used to substitute non-ascii utf8 characters (2, 3 and 4 multibyte encodings are substituted by 2, 3 and 4 glyphs correspondingly).Checklist
develop