fix: an error when an anonymous user fills the form

[arunk]

SaveDBAction.execute method uses request.user for
form_user but request.user is not an instance of User for AnonymousUsers therefore we need to check for whether the user is logged in or not

[fsbraun]

@arunk Well spotted! Thank you!

[arunk]

Do you mean record the key "login_required" in the FormEntry ? or do you mean record that the user was anonymous?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@20d0f69). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   62.79%           
=======================================
  Files           ?       21           
  Lines           ?     1419           
  Branches        ?      219           
=======================================
  Hits            ?      891           
  Misses          ?      487           
  Partials        ?       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arunk]

I'm also having trouble figuring out where the Action is supposed to go. I have finally put it in apps.py in the ready method, where I load the actions module and register an object to do the FormAction. I'm not sure if this is the right approach. If it is, then I'll submit another PR, to update the docs saying how to do this. If the FormAction should be in another file, I tried forms.py, actions.py none of them worked. Then let me know and I'll do likewise and update the README.rst and submit a PR

[fsbraun]

Now, this should record any logged-in user and leave the "form_user" entry empty (None) if no user was logged. That seems reasonable to me.

[fsbraun]

I'm also having trouble figuring out where the Action is supposed to go. I have finally put it in apps.py in the ready method, where I load the actions module and register an object to do the FormAction. I'm not sure if this is the right approach. If it is, then I'll submit another PR, to update the docs saying how to do this. If the FormAction should be in another file, I tried forms.py, actions.py none of them worked. Then let me know and I'll do likewise and update the README.rst and submit a PR

Yes, that works. The form action has to be somewhere where it is imported upon django startup. I have often imported them from models.py but that's not so helpful for forms that are not associated with models. An update of the README would be awesome!