fix: Send mail action failed

[fsbraun]

This PR fixes the send_mail_action and adds a test for it

Summary by Sourcery

Fix the send mail action to handle missing request headers and add tests for the action.

Bug Fixes:

• Handle missing "User-Agent" and "Referer" headers in the request to prevent errors.

Tests:

• Add tests for the send mail action, including cases with and without recipients.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a bug in the send_mail action where emails were not being sent to the specified recipients. It also adds tests for the send_mail action.

Sequence diagram for the fixed send_mail action flow

sequenceDiagram
    participant Form
    participant SendMailAction
    participant DjangoMail

    Form->>SendMailAction: execute(form, request)
    SendMailAction->>SendMailAction: get_parameter(sendemail_recipients)
    SendMailAction->>SendMailAction: split recipients string
    SendMailAction->>SendMailAction: render templates
    alt no recipients
        SendMailAction->>DjangoMail: mail_admins(subject, message, html_message)
    else has recipients
        SendMailAction->>DjangoMail: send_mail(subject, message, from_mail, recipients, html_message)
    end

Loading

Class diagram for the updated SendMailAction class

classDiagram
    class SendMailAction {
        +execute(form, request)
        -get_parameter(form, param_name)
        -subject: str
        -from_mail: str
    }
    note for SendMailAction "Fixed recipients handling and template rendering"

Loading

File-Level Changes

Change	Details	Files
Fix the send_mail action to handle recipient email addresses correctly.	Change the way recipient email addresses are parsed from the action parameters. Use the split() method to split the recipient string into a list of email addresses. Handle cases where the recipient string is empty by sending the email to the site admins. Add handling for missing User-Agent and Referer headers in the request.	djangocms_form_builder/actions.py
Add tests for the send_mail action.	Add a test case to verify that the send_mail action sends emails to the correct recipients. Add a test case to verify that the email subject and body are rendered correctly. Add a test case to verify that the action falls back to sending emails to the site admins when no recipients are specified.	tests/test_actions.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding email address validation before attempting to send. This would provide better error messages and fail faster than waiting for send_mail to raise an exception.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟡 Testing: 1 issue found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[fsbraun]

@sourcery-ai review

[sourcery-ai]

Hey @fsbraun - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Using whitespace splitting for email addresses is risky. Consider using a more robust delimiter like commas.

Email addresses might contain spaces (e.g., in quoted strings). This could lead to invalid recipient lists.

[sourcery-ai]

issue (code-quality): Extract duplicate code into method (extract-duplicate-method)