Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for djangoCMS 4.x #226

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

filipweidemann
Copy link
Contributor

Description

This PR adds support for the new djangoCMS 4.x.
It closes #221 and uses the outlined approach discussed there.

I also refactored the test setup and added the Mixin/Fixture of djangocms-text-ckeditor4 to support both djangoCMS 3 & 4.

All tests are green locally, I'd be happy to get this merged if everything is looking good to you @fsbraun :)

Related resources

Checklist

  • [ x ] I have opened this pull request against master
  • [ x ] I have added or modified the tests when changing logic
  • [ x ] I have followed the conventional commits guidelines to add meaningful information into the changelog
  • [ x ] I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Jul 22, 2024

This PR supersedes #201

@filipweidemann
Copy link
Contributor Author

Oh man I knew it, I'll quickly sort the test files as well...

@filipweidemann
Copy link
Contributor Author

@fsbraun I isorted the tests/ directory as well, sorry for the miss there.

Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipweidemann Thank you so much for this nice PR!

@fsbraun fsbraun merged commit 9d0a24b into django-cms:master Jul 22, 2024
12 checks passed
@filipweidemann
Copy link
Contributor Author

Ofc, thanks for the merge as well :)

@fsbraun
Copy link
Sponsor Member

fsbraun commented Jul 23, 2024

@filipweidemann Released as version 4.0 🎉

@filipweidemann
Copy link
Contributor Author

@fsbraun lovely, thank you so much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in dijango-cms 4.1 and fronted
2 participants