Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Store API and initial documentation. #1784

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

tim-schilling
Copy link
Member

@tim-schilling tim-schilling commented May 17, 2023

Description

Initial commit for https://github.com/orgs/jazzband/projects/9/views/1 (serializable toolbar).

This starts the process of creating a serializable branch in the repo for that work. I'm not sure we want to merge this work alongside the working toolbar.

This is based on the work from #1432

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this!

debug_toolbar/store.py Outdated Show resolved Hide resolved
debug_toolbar/store.py Outdated Show resolved Hide resolved
docs/changes.rst Show resolved Hide resolved
@matthiask matthiask deleted the branch django-commons:serializable May 24, 2023 08:57
@matthiask matthiask closed this May 24, 2023
@matthiask matthiask reopened this May 24, 2023
@matthiask
Copy link
Member

Sorry, I didn't mean to close this.

If the serialization logic begins throwing exceptions we can consider
subclassing the encoder class and using force_str on the object itself.
@matthiask matthiask merged commit c70e89f into django-commons:serializable Jun 23, 2023
@matthiask
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants